ID-15: Fix asymmetric invalid refresh token test#741
Merged
karlnaden merged 1 commit intoonc-healthit:mainfrom Feb 6, 2026
Merged
Conversation
karlnaden
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses Issue #700 by fixing the SMARTInvalidTokenRefreshTest to support asymmetric authentication. Previously, the test did not interpret the asymmetric auth type correctly and failed to send the required client_assertion and client_assertion_type parameters. This meant the test was effectively checking unauthenticated behavior rather than authenticated asymmetric behavior.
Changes
Modified
lib/onc_certification_g10_test_kit/smart_invalid_token_refresh_test.rb to use SMARTAppLaunch::ClientAssertionBuilder for generating the client assertion when asymmetric auth is configured. Updated spec/onc_certification_g10_test_kit/smart_invalid_token_refresh_test_spec.rb with a new context to verify the presence of client assertion parameters in the request.
Updated
spec/onc_certification_g10_test_kit/smart_invalid_token_refresh_test_spec.rb with a new context to verify the presence of client assertion parameters in the request.
End-to-End Testing Steps
Start Inferno:
Select Options:
Select Preset:
Navigate to Test:
Run Test:
Verify: